Skip to content

[various] Removed references to deprecated TestWindow APIs #4558

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Merged
merged 6 commits into from
Aug 3, 2023

Conversation

pdblasi-google
Copy link
Contributor

@pdblasi-google pdblasi-google commented Jul 24, 2023

Removed references to deprecated TestWindow APIs.

Closes flutter #122912

Pre-launch Checklist

  • I read the [Contributor Guide] and followed the process outlined there for submitting PRs.
  • I read the [Tree Hygiene] wiki page, which explains my responsibilities.
  • I read and followed the [relevant style guides] and ran the auto-formatter. (Unlike the flutter/flutter repo, the flutter/packages repo does use dart format.)
  • I signed the [CLA].
  • The title of the PR starts with the name of the package surrounded by square brackets, e.g. [shared_preferences]
  • I listed at least one issue that this PR fixes in the description above.
  • I updated pubspec.yaml with an appropriate new version according to the [pub versioning philosophy], or this PR is [exempt from version changes].
  • I updated CHANGELOG.md to add a description of the change, [following repository CHANGELOG style].
  • I updated/added relevant documentation (doc comments with ///).
  • I added new tests to check the change I am making, or this PR is [test-exempt].
  • All existing and new tests are passing.

@reidbaker reidbaker self-requested a review July 24, 2023 20:28
Copy link
Contributor

@reidbaker reidbaker left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

approval % failing test. I updated the branch in case it was either a flake or fixed upstream

Copy link
Contributor

@Piinks Piinks left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Flutter_LGTM

@Piinks
Copy link
Contributor

Piinks commented Jul 24, 2023

Looks like the cranky checks are formatting. This repo uses dart format.

@pdblasi-google
Copy link
Contributor Author

@reidbaker I think this should be good to go now, let me know if I'm missing anything.

@reidbaker reidbaker added the autosubmit Merge PR when tree becomes green via auto submit App label Jul 28, 2023
@auto-submit auto-submit bot removed the autosubmit Merge PR when tree becomes green via auto submit App label Jul 28, 2023
@auto-submit
Copy link
Contributor

auto-submit bot commented Jul 28, 2023

auto label is removed for flutter/packages, pr: 4558, due to - The status or check suite android-platform_tests CHANNEL:master PACKAGE_SHARDING:--shardIndex 2 --shardCount 6 has failed. Please fix the issues identified (or deflake) before re-applying this label.

engine-flutter-autoroll added a commit to engine-flutter-autoroll/flutter that referenced this pull request Aug 3, 2023
auto-submit bot pushed a commit to flutter/flutter that referenced this pull request Aug 3, 2023
flutter/packages@4e4961a...d00c1f9

2023-08-03 49699333+dependabot[bot]@users.noreply.github.com Bump github/codeql-action from 2.21.1 to 2.21.2 (flutter/packages#4637)
2023-08-03 [email protected] Roll Flutter from b3f99ff to c00d241 (12 revisions) (flutter/packages#4640)
2023-08-03 [email protected] [path_provider] Add getApplicationCachePath() - implementations (flutter/packages#4619)
2023-08-03 [email protected] [various] Removed references to deprecated `TestWindow` APIs (flutter/packages#4558)
2023-08-02 49699333+dependabot[bot]@users.noreply.github.com Bump actions/labeler from 4.1.0 to 4.3.0 (flutter/packages#4432)
2023-08-02 [email protected] [go_router_builder]  Add go_router StatefulShellRoute support to go_router_builder (flutter/packages#4238)
2023-08-02 [email protected] [Tooling] Add google owned cache for dependencies as an option in ci (flutter/packages#4567)
2023-08-02 [email protected] Roll Flutter from 1d59196 to b3f99ff (32 revisions) (flutter/packages#4634)
2023-08-02 [email protected] [go_router_builder] Support `ShellRouteData` without `const` constructor  (flutter/packages#4627)
2023-08-02 49699333+dependabot[bot]@users.noreply.github.com Bump github/codeql-action from 2.21.0 to 2.21.1 (flutter/packages#4573)

If this roll has caused a breakage, revert this CL and stop the roller
using the controls here:
https://autoroll.skia.org/r/flutter-packages-flutter-autoroll
Please CC [email protected],[email protected] on the revert to ensure that a human
is aware of the problem.

To file a bug in Flutter: https://github.com/flutter/flutter/issues/new/choose

To report a problem with the AutoRoller itself, please file a bug:
https://bugs.chromium.org/p/skia/issues/entry?template=Autoroller+Bug

Documentation for the AutoRoller is here:
https://skia.googlesource.com/buildbot/+doc/main/autoroll/README.md
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
autosubmit Merge PR when tree becomes green via auto submit App p: dynamic_layouts The dynamic_layouts package p: google_maps_flutter p: google_sign_in platform-android
Projects
None yet
Development

Successfully merging this pull request may close these issues.

Update flutter/packages to use new TestFlutterView API
4 participants